Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add attribute remove_source_branch_after_merge to projects #289

Merged
merged 1 commit into from
Jun 3, 2020
Merged

add attribute remove_source_branch_after_merge to projects #289

merged 1 commit into from
Jun 3, 2020

Conversation

apricote
Copy link
Contributor

@apricote apricote commented Apr 1, 2020 •
edited
Loading

Closes #200

@apricote
Copy link
Contributor Author

apricote commented Apr 6, 2020

I rebased on the current master (that includes xanzy/[email protected]) and the PR is no longer blocked. All Unit Tests are green.

@ringods
Copy link
Contributor

ringods commented Jun 2, 2020

Hello @apricote, can you rebase once more? Based on the test result outcome, I will merge shortly after that.

@apricote
Copy link
Contributor Author

apricote commented Jun 2, 2020

@ringods I rebased on current master (bef89771b574ec408f067b625a92bdb38cd3c589) but the CI failures are not related to the resource I modified.

@ringods
Copy link
Contributor

ringods commented Jun 3, 2020

@apricote can you rebase once more? Branch master contains an updated go-gitlab library which already fixes one test. But due to #319, it is possible another test can still fail but I will ignore that for merging this PR.

@apricote
Copy link
Contributor Author

apricote commented Jun 3, 2020

Done @ringods. Acceptence Tests for ce look fine now. Thanks for your work on this project :)

@ringods ringods merged commit a06b19d into gitlabhq:master Jun 3, 2020
@ringods
Copy link
Contributor

ringods commented Jun 3, 2020

Tnx for the contribution.

@apricote apricote deleted the feature/implement-#200 branch July 2, 2020 13:17
ahmet2mir pushed a commit to ahmet2mir/terraform-provider-gitlab that referenced this pull request Sep 15, 2020
@ringods
Merge pull request gitlabhq#289 from apricote/feature/implement-#200
04d63b2 
add attribute remove_source_branch_after_merge to projects
@github-actions github-actions bot locked and limited conversation to collaborators Nov 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
documentation size/XS
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for option "remove_source_branch_after_merge" for projects
2 participants
@apricote @ringods