Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More group options #362

Merged
merged 29 commits into from
Sep 11, 2020
Merged

More group options #362

merged 29 commits into from
Sep 11, 2020

Conversation

justinkillen
Copy link
Contributor

@justinkillen justinkillen commented Jul 19, 2020 •
edited
Loading

Supersedes #257, #331
Fixes #210

Add support for gitlab group fields:

Fields added:

ShareWithGroupLock (bool)
RequireTwoFactorAuth (bool)
TwoFactorGracePeriod (int)
ProjectCreationLevel (string: "noone", "maintainer", "developer")
SubGroupCreationLevel (string: "owner", "maintainer")
AutoDevopsEnabled (bool)
EmailsDisabled (bool)
MentionsDisabled (bool)

@ghost ghost added the size/XL label Jul 19, 2020
@justinkillen justinkillen mentioned this pull request Jul 19, 2020
Closed
@ghost ghost added size/L and removed size/XL labels Jul 25, 2020
@ghost ghost added size/XL and removed size/L labels Jul 26, 2020
@justinkillen
Copy link
Contributor Author

For https://github.com/terraform-providers/terraform-provider-gitlab/issues/210

@justinkillen
Copy link
Contributor Author

I'm new to golang, and it's showing. Could use some help on setting up the tests correctly.

@ghost ghost added size/L and removed size/XL labels Jul 26, 2020
@ghost ghost added size/XL and removed size/L labels Jul 26, 2020
@ghost ghost added the documentation label Jul 26, 2020
@justinkillen justinkillen changed the title [WIP] More group options More group options Jul 26, 2020
@justinkillen
Copy link
Contributor Author

@roidelapluie ready for review

@roidelapluie
Copy link
Collaborator

@armsnyder is ther amy chance you can review this? thanks!

@armsnyder armsnyder self-requested a review September 11, 2020 01:05
armsnyder
armsnyder requested changes Sep 11, 2020
View reviewed changes
Copy link
Collaborator

@armsnyder armsnyder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the high quality contribution and the improvements to the test. I left one question and two docs suggestions.

gitlab/resource_gitlab_group.go Show resolved Hide resolved
website/docs/r/group.html.markdown Outdated Show resolved Hide resolved
website/docs/r/group.html.markdown Outdated Show resolved Hide resolved
@armsnyder
Copy link
Collaborator

I'm new to golang, and it's showing.

😮

@armsnyder armsnyder merged commit 01b429b into gitlabhq:master Sep 11, 2020
@armsnyder armsnyder mentioned this pull request Sep 11, 2020
Merged
@armsnyder armsnyder mentioned this pull request Sep 21, 2020
Closed
@justinkillen justinkillen deleted the more_group_options branch October 14, 2020 15:32
@github-actions github-actions bot locked and limited conversation to collaborators Nov 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@armsnyder armsnyder armsnyder approved these changes

@roidelapluie roidelapluie roidelapluie left review comments

Assignees
No one assigned
Labels
documentation size/XL
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for project_creation_level on groups
3 participants
@justinkillen @roidelapluie @armsnyder