Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Breaking] Fix gitlab_project and gitlab_project_share relationship #421

Merged
merged 1 commit into from
Sep 18, 2020

Conversation

armsnyder
Copy link
Collaborator

  • resource/gitlab_project: remove shared_with_groups attribute
  • resource/gitlab_project_share: fix update failing to change access_level

Part of #411 preparation

See discussion in #416

Fixes #219

- gitlab_project: remove shared_with_groups attribute
- gitlab_project_share: fix update failing to change access_level
@armsnyder armsnyder added the breaking change Issue or Pull Request which would introduce a breaking change label Sep 18, 2020
Copy link
Collaborator

@roidelapluie roidelapluie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@armsnyder armsnyder merged commit b125af0 into gitlabhq:master Sep 18, 2020
@armsnyder armsnyder deleted the rm-project-share-attr branch September 18, 2020 07:25
@github-actions github-actions bot locked and limited conversation to collaborators Nov 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
breaking change Issue or Pull Request which would introduce a breaking change
Development

Successfully merging this pull request may close these issues.

gitlab_project_share_group not working
2 participants