Add cacert_file and insecure options to the provider.
#5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These settings can be used to configure the level of SSL verification performed by the provider. * `cacert_file` allows for the provision of an alternate ca cert, for locally-signed or self-signed operations. * `insecure` allows SSL verification to be turned off completely. It is not suggested as a first option. Targets https://github.com/terraform-providers/terraform-provider-gitlab/issues/4
tombuildsstuff
approved these changes
Sep 25, 2017
There was a problem hiding this comment.
Hey @richardc
Thanks for this PR - apologies for the delay in reviewing this; I've taken a look and this LGTM :)
Thanks!
|
So I'm a little confused, if this has two approvals, why's it not been merged? |
|
@richardc in general we tend to approve and then let the original contributor merge (when they have permission) - but I'll merge this now :) |
tombuildsstuff
added a commit
that referenced
this pull request
Sep 26, 2017
|
@tombuildsstuff is that flow documented somewhere? I don't see it in the README.md and there's no CONTRIBUTING.md |
|
@richardc I've found this in the main repository: https://github.com/hashicorp/terraform/blob/master/docs/maintainer-etiquette.md#merging (it should probably be linked from the CONTRIBUTING.md in each provider though) :) |
cehoffman
pushed a commit
to VertivSRE/terraform-provider-gitlab
that referenced
this pull request
Jan 23, 2018
Add `cacert_file` and `insecure` options to the provider.
cehoffman
pushed a commit
to VertivSRE/terraform-provider-gitlab
that referenced
this pull request
Jan 23, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These settings can be used to configure the level of SSL verification
performed by the provider.
cacert_fileallows for the provision of an alternate ca cert, forlocally-signed or self-signed operations.
insecureallows SSL verification to be turned off completely. It isnot suggested as a first option.
Targets https://github.com/terraform-providers/terraform-provider-gitlab/issues/4