Add support for gitlab branch protection #68
Conversation
…er-gitlab into more-resources
ghost
added
the
|
@radeksimko @grubernaut @roidelapluie Please take a look |
|
@radeksimko @grubernaut @roidelapluie Please review |
|
hey @waseem-h would love to, but I left Hashicorp over a year ago. Will likely need a current employee to review this for you. 😄 |
|
Please add acceptance tests :) |
|
Missing:
Thanks!! |
| ) | ||
|
|
||
| func resourceGitlabBranchProtection() *schema.Resource { | ||
| acceptedAccessLevels := []string{ |
There was a problem hiding this comment.
How could I set access level to "No one"?
There was a problem hiding this comment.
is it possible to get that list from elsewhere?
There was a problem hiding this comment.
Could you please add no one and maintainer here?
There was a problem hiding this comment.
is it possible to get that list from elsewhere?
@roidelapluie should we sync the branch with the upstream master and then use the accessLevel map from https://github.com/terraform-providers/terraform-provider-gitlab/blob/master/gitlab/util.go#L140
|
Once https://github.com/terraform-providers/terraform-provider-gitlab/pull/83 is merged, we should be able to add |
|
#83 is merged but there is still no acceptance tests for this PR |
… new attributes and fix others attributes' name
The site's markdown processor tries to automatically turn URLs into links, but this one doesn't go anywhere, so let's style it as a code span.
|
@roidelapluie there is a 401 error in test case
which is causing the pipeline to fail subsequently. Can you please look into this? |
|
@roidelapluie @bilby91 @mcanevet can you plz take a look? |
|
pending #118 is merged for green CI test |
…lack Implement gitlab service slack
Allow Deploy Keys imports
Update user datasource: allow searching by id and add attributes
…e_url website: make example server URL non-clickable
Signed-off-by: Julien Pivotto <[email protected]>
I've added gitlab branch protection support since it was needed for our usecase and others might also require it. We're using a local binary of this instead of the global release for now. We want it to be merged so that our dependency on a local binary is removed.