-
Notifications
You must be signed in to change notification settings - Fork 319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add users datasource #79
Conversation
…arameters to extern_uid & extern_provider
* `created_at` - Date the user was created at. | ||
* `state` - Whether the user is active or blocked. | ||
* `external` - Whether the user is external. | ||
* `extern_uid` - The external UID of the user. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cannot the extern_provider
field be also exposed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There were actually a lot of missing properties. I added them all, including extern_provider
that is named provider
to match the API.
…tions to extern_*
eb28bd0
to
5e577ef
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
5e577ef
to
dcd508e
Compare
Thanks for reviewing @pdecat! Didn't see there were tabs instead of spaces :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
What about acceptance tests results?
Thanks @pdecat! Here's the acceptance test result:
|
Thanks!! |
Add new
gitlab_users
datasource that returns a list of users.It takes optional arguments such as
order_by
,sort
andsearch
, full list in the included documentation.Examples: