-
Notifications
You must be signed in to change notification settings - Fork 319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use new access levels permissions #83
Conversation
f0c2307
to
7186d48
Compare
7186d48
to
73e05df
Compare
Can you please tell me which release of gitlab is required to support MAINTAINER? for the changelog. |
Also if by accident current gitlab still allows master in the API, let's keep master |
gitlab/util.go
Outdated
"owner": gitlab.OwnerPermission, | ||
|
||
// Deprecated | ||
"master": gitlab.MasterPermissions, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this map to gitlab.MaintainerPermissions
as in accessLevelNameToValue
?
73e05df
to
c0675af
Compare
@roidelapluie renaming of master role to maintainer occurred in v11.0 : https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/19080 but this should be backward compatible as internally it uses the same value (40). |
"owner": gitlab.OwnerPermission, | ||
|
||
// Deprecated | ||
"master": gitlab.MaintainerPermissions, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this!!
https://github.com/xanzy/go-gitlab/blob/cd1e3f03a766cd7f9a7d2257926039b77f2c7710/gitlab.go#L66-L77