Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new access levels permissions #83

Merged
merged 1 commit into from
Feb 8, 2019

Conversation

@ghost ghost added the size/XS label Feb 2, 2019
@ghost ghost added size/S and removed size/XS labels Feb 2, 2019
@roidelapluie
Copy link
Collaborator

Can you please tell me which release of gitlab is required to support MAINTAINER? for the changelog.

@roidelapluie
Copy link
Collaborator

Also if by accident current gitlab still allows master in the API, let's keep master

gitlab/util.go Show resolved Hide resolved
gitlab/util.go Outdated
"owner": gitlab.OwnerPermission,

// Deprecated
"master": gitlab.MasterPermissions,
Copy link
Contributor

@pdecat pdecat Feb 7, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this map to gitlab.MaintainerPermissions as in accessLevelNameToValue?

https://github.com/terraform-providers/terraform-provider-gitlab/pull/83/files#diff-91172e3ffafe3f9c1d8801e15c42cc0aR22

@mcanevet
Copy link
Author

mcanevet commented Feb 7, 2019

@roidelapluie renaming of master role to maintainer occurred in v11.0 : https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/19080 but this should be backward compatible as internally it uses the same value (40).

"owner": gitlab.OwnerPermission,

// Deprecated
"master": gitlab.MaintainerPermissions,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this!!

@roidelapluie roidelapluie merged commit f392213 into gitlabhq:master Feb 8, 2019
@mcanevet mcanevet deleted the new_access_levels branch February 9, 2019 07:14
@github-actions github-actions bot locked and limited conversation to collaborators Nov 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Development

Successfully merging this pull request may close these issues.

3 participants