Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OnePasswordAccountConfigured fails if user used my..1password.com on login. #274

Open
utamas opened this issue May 22, 2024 · 0 comments
Open

OnePasswordAccountConfigured fails if user used my..1password.com on login. #274

utamas opened this issue May 22, 2024 · 0 comments

Comments

@utamas
Copy link

utamas commented May 22, 2024

If user used my.1password.com on 1password UI (and enabled 1pwd CLI integration) then check specific to a corporate account will fail.

What if two checks were provided?

  1. One that asserts the domain of the email (we have corporate emails).
  2. Check for login URL (like current implementation)

Alternatively, OnePasswordAccountConfigured could just check if op account list contains the text itself instead of it's URL form?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@utamas