Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support 'enableTagOverride' for consul backend #347

Open
difro opened this issue Feb 19, 2016 · 7 comments
Open

support 'enableTagOverride' for consul backend #347

difro opened this issue Feb 19, 2016 · 7 comments

Comments

@difro
Copy link

difro commented Feb 19, 2016

consul 0.6 landed with 'enableTagOverride' which disables 'anti-entropy' feature for each service being registered. This lets external agents to modify tags for already registered services.

Since this has been merged into consul go api,
It'd be great registrator also supported this feature.

I'm thinking maybe, something like SERVER_ENABLETAGOVERRIDE=true env ?

@thefab
Copy link

thefab commented Apr 6, 2016

+1, required to properly deal with master/slave status on services (the master/slave tag is set after a leader election)

@difro
Copy link
Author

difro commented Apr 7, 2016

I'm thinking maybe it'd be ok even if 'enableTagOverride' was always set to true.

Should be a 1~2 line PR. Will cook one up soon.

@thutcheson-jha
Copy link

+1

@bitsofinfo
Copy link

+1

3 similar comments
@bmudda
Copy link

bmudda commented Dec 5, 2016

+1

@kkonstantin42
Copy link

+1

@phuslu
Copy link

phuslu commented Apr 25, 2017

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants