-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Respect the domainname if set #19
Comments
I don't think I understand fully. What configuration is this an example for? |
Docker-compose https://docs.docker.com/compose/compose-file/ |
Resolvable currently registers What happens if you set the container name, rather than its hostname? The domain name option is not used by resolvable. Two aliases are added by resolvable right now, |
While the compose docs do talk about domainname, I don't actually see a way to set that with It seems resolvable handles this naively right now, which enables your workaround. Resolvable adds the hostname as an alias without parsing it at all. I'm actually a little confused why your workaround doesn't result in |
Alright, I just verified locally that resolvable only adds the short hostname, which is why your workaround functions. Maybe it should add the full hostname of the container when it's started with one. That would resolve #20, too. |
that would be an option, also to note that docker-compose does everything perfectly valid. The FQDN is always composed from hostname + domainname. It is also what I originally asked for, to also respect the domain name and use the FQDN or full hostname. |
And about the confusion: docker-compose assumes: hosntame.domainname and automatically splits the hostname into those parts. |
To give a bit of an insight also: The reason I need the hostname is that we also use docker as development environment and there is a possibility that there are different versions of containers with the same hostname. Those containers should be reachable via the hostname and not every time through the new random container name. The problem now raises here: We unfortunately also currently have proxies in place to access the internet, thus we need to set exceptions. The approach to solve this is to assume that all docker domains end on .docker and this is the actual exception for the proxy. The problem is that the hostname is never added as |
#22 implements fqdn names. You can even give it a try by using Just a quick note on docker-compose: you can specify fqdn names 2 ways:
Or define separate
|
Currently the domainname is ignored, if the hostname should be resolvable as 'hostname.docker' one needs to set the hostname to 'hostname.docker' and the domainname to 'docker'.
Example config:
Currently needed workaround:
The text was updated successfully, but these errors were encountered: