Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove require('url') usage #1140

Closed
pzuraq opened this issue Aug 21, 2020 · 3 comments · Fixed by #1155
Closed

Remove require('url') usage #1140

pzuraq opened this issue Aug 21, 2020 · 3 comments · Fixed by #1155

Comments

@pzuraq
Copy link
Member

pzuraq commented Aug 21, 2020

We currently use require('url') in places where we parse the URLs to see if they're safe to execute, specifically for Node. We should replace this with the URL API.
@zackthehuman
Copy link
Contributor

It looks like there are only a few (or one?) places where this happens. I have some time to pick this up if this is a simple API swap. Are we OK with the lack of IE support?

@rwjblue
Copy link
Member

rwjblue commented Aug 27, 2020

I think that we'd fallback to the current system if typeof URL === 'undefined' (RE: IE support).

@rwjblue rwjblue mentioned this issue Sep 2, 2020
Merged
@rwjblue
Copy link
Member

rwjblue commented Sep 2, 2020

FYI - I ended up needing to tackle this due to the regression reported in #1141 (see #1155).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ensure protocolForUrl works in [email protected] environment glimmerjs/glimmer-vm
3 participants
@rwjblue @zackthehuman @pzuraq