Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

on the develop branch, I cannot execute the example dashboard #29

Closed
bdice opened this issue Oct 2, 2018 · 2 comments
Closed

on the develop branch, I cannot execute the example dashboard #29

bdice opened this issue Oct 2, 2018 · 2 comments
Labels
bug Something isn't working

Comments

@bdice
Copy link
Member

bdice commented Oct 2, 2018

Original report by Jens Glaser (Bitbucket: jens_glaser, GitHub: jglaser).


I have to manually call the prepare() method:

#!/usr/bin/env python3
from signac_dashboard import Dashboard
from signac_dashboard.modules import ImageViewer


if __name__ == '__main__':
    dashboard = Dashboard(modules=[ImageViewer()])
    dashboard.prepare()
    dashboard.run(host='localhost', port=8888)

I believe that should be unnecessary

@bdice
Copy link
Member Author

bdice commented Oct 2, 2018

Original comment by Bradley Dice (Bitbucket: bdice, GitHub: bdice).


Good catch - I changed the way the dashboard runs. Instead of the run function, now it uses the main function.

@bdice
Copy link
Member Author

bdice commented Oct 2, 2018

Original comment by Bradley Dice (Bitbucket: bdice, GitHub: bdice).


Resolved by PR #10.

@bdice bdice closed this as completed Oct 2, 2018
@bdice bdice added major bug Something isn't working labels Jan 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant