Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type hints #404

Open
csadorf opened this issue Dec 17, 2020 · 4 comments
Open

Add type hints #404

csadorf opened this issue Dec 17, 2020 · 4 comments

Comments

@csadorf
Copy link
Contributor

csadorf commented Dec 17, 2020

The source of signac-flow would likely be more readable and more bug-resilient with type hints.

@bdice
Copy link
Member

bdice commented Jan 2, 2021

I would suggest using the approach from the PR linked below to automatically generate some type hints, and then manually refine them. glotzerlab/signac#313

@kidrahahjo
Copy link
Collaborator

I'll work on implementing this!

@kidrahahjo kidrahahjo self-assigned this Jan 25, 2021
@vyasr
Copy link
Contributor

vyasr commented Jan 25, 2021

@kidrahahjo while this feature would be nice, I would recommend working on something else for the moment if you have the time. There are higher priority items to be worked on at the moment, in particular I would focus on things related to getting actual aggregation working. Working through #362 and updating that checklist with remaining items would be very helpful.

If you want to wait on that for a bit while issues with the current code base get ironed out after the 0.12 release, then I would suggest trying to work through some of the more self-contained issues in our backlog. Considering the amount of code in flow and the fact that this kind of change would require eventually modifying every file (although of course you can stage it to avoid introducing lots of merge conflicts), I would like to get our issue list shorter before working on something bigger like this.

For starters, I'd suggest the following issues:

@kidrahahjo
Copy link
Collaborator

@vyasr I agree on what you suggested. I had a chat with @bdice on slack, I will start working on introducing actual aggregation as soon as we release flow 0.12.0. With respect to the point that this should be handled after we're done with some of the already existing issues, I think you're definitely right. I will have a look at the mentioned issues and see what I can do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants