Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LDAP - time zones selection not applied #13682

Open
2 tasks done
keguira opened this issue Dec 29, 2022 · 1 comment
Open
2 tasks done

LDAP - time zones selection not applied #13682

keguira opened this issue Dec 29, 2022 · 1 comment
Labels

Comments

@keguira
Copy link

keguira commented Dec 29, 2022

Code of Conduct

  • I agree to follow this project's Code of Conduct

Is there an existing issue for this?

  • I have searched the existing issues

Version

10.0.5

Bug description

After activating the time zone in database all of the application take it into account (users, general configuration, etc) except of the LDAP configuration.

In the following elements, the selector still indicates GMT offsets in place of timezone selection :

  • Setup > Authentication > Setup
  • Setup > Authentication > LDAP directories > "an element" > Advanced information

For information : I also raised a ticket on documentation to further the impacts of these configurations and how they interact with everything else as time handling can be hard to understand.

Relevant log output

No response

Page URL

No response

Steps To reproduce

  1. create a new instance of GLPI
  2. Activate timezones like asked in documentation
  3. Create a new LDAP configuration

Your GLPI setup information

No response

Anything else?

I use a single instance of GLPI with multiple LDAP directories located around the world. Users have their own timezone, Active directories servers have their own time zone (north america, north africa, multiple countries in europe).

@cedric-anne cedric-anne added this to the 10.0.7 milestone Jan 30, 2023
@cedric-anne
Copy link
Member

As far as I see, these offsets are used to recompute the modifytimestamp field to a GMT date that is then stored in the date_sync field of the user, in order to be compared, on next synchronization, with the modifytimestamp recomputed the same way, to determine whether the user has been updated.

When timezones are enabled in GLPI, timestamps are converted from current user timezone to GMT when inserted in DB, so date_sync field value is should be converted to a timestamp in current user timezone instead of GMT. I do not know if it is more than a display bug here. A test should probably be added in our test suite to verify that all works as expected.

@cedric-anne cedric-anne removed this from the 10.0.7 milestone Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants