Enhance PHP 8 compatibility #8051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trasher
approved these changes
Oct 2, 2020
cedric-anne
force-pushed
the
feature/php8
branch
2 times, most recently
from
b19e7df to
995ca27
Compare
cedric-anne
force-pushed
the
feature/php8
branch
2 times, most recently
from
01eec4a to
d5c6a64
Compare
Merged
cedric-anne
force-pushed
the
feature/php8
branch
3 times, most recently
from
de05781 to
15c3a28
Compare
cedric-anne
force-pushed
the
feature/php8
branch
from
15c3a28 to
b1f53ec
Compare
- Add PHP 8.0-rc to Github Actions test suite - Make XML RPC tests optional (extension is not available on PHP 8) - Fix Plugin::getGlpiPrever() test on PHP 8 - Fix named @dataProvider arguments - Upgrade atoum to 4.x - Allow installation of incompatible deps for RC versions of PHP image - Update sabre/* components - Add LDAP removed methods to composer-require-checker exceptions - Patch TCPDF - Update simplepie/simplepie component
cedric-anne
force-pushed
the
feature/php8
branch
from
e38e30b to
9c7f289
Compare
cedric-anne
requested review from
trasher and
orthagh
and removed request for
trasher and
orthagh
orthagh
approved these changes
Nov 18, 2020
trasher
approved these changes
Nov 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR only fixes test suite. I did not performed manual tests yet.
Can be reviewed commit by commit.