Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HyperMAML warmup - fast_parameters are not updated #6

Open
kidq330 opened this issue Jun 9, 2024 · 0 comments
Open

HyperMAML warmup - fast_parameters are not updated #6

kidq330 opened this issue Jun 9, 2024 · 0 comments

Comments

@kidq330
Copy link

kidq330 commented Jun 9, 2024

Reading through and trying to refactor code for the three MAML models I might've come across a bug in the logic - when warmup is used for HyperMAML, and gradients are computed for the fast_parameters list in _update_network_weights, it isn't updated with the gradient values in the same way it is in classic MAML's set_forward method, after each gradient step.
I'm 90% sure this isn't the intended behaviour, hope to hear your thoughts on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant