Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes in how synonyms are declared? #130

Closed
BenMerSci opened this issue Jan 7, 2025 · 4 comments
Closed

Changes in how synonyms are declared? #130

BenMerSci opened this issue Jan 7, 2025 · 4 comments

Comments

@BenMerSci
Copy link

Hi @dimus!

Is it possible there was any recent changes in how an entry is declared Synonym, with the deprecated isSynonym key (or even with the 'new' key taxonomicStatus)?

I have a test on my side that was querying for 'Diptera' from CatalogueOfLife:

(https://verifier.globalnames.org/api/v1/verifications/Diptera?capitalize=true&all_matches=true&data_sources=1)

and it was working around the key isSynonym to keep/remove the entries that were and were not synonyms, and now my tests suddenly fails and I've dig around and all I can currently see on my side is a change in the isSynonym key, as previously the test was checking the length of the previously returned query for Diptera, it was dropping the synonyms and ended up with only one entry for Diptera from CatalogueOfLife, but now the two entries are declared Synonym and are dropped.

Did anything change?

Thank you, and happy new year!

@dimus
Copy link
Member

dimus commented Jan 7, 2025

Hi @BenMerSci sorry about this problem and thank you for reporting it! We are having quite unique situation from January 5th to ~January 15th. The university computer center is shutdown during this period due to upgrade of its electrical supply system. We recreated backup services at a temporary location and until the computer center is back we serve all our programs from this new place. It sounds like a problem is with data migration. Let me investigate

@dimus
Copy link
Member

dimus commented Jan 8, 2025

the results should be more sane now, but I also notice another problem, Diptera which is not a synonym is not appearing as the 'BestResult'.

I have tests that check the code itself, but most of the issues you are reporting are coming from discrepancies in the postgresql-stored data. I definitely need to make tests that test data integrity!

@BenMerSci
Copy link
Author

The problem I encountered specifically with Diptera and CatalogueOfLife is resolved (the plant Diptera is considered Synonym and the insect Diptera is Accepted).

I'll let you see if you want to close this issue now or not!

Also, if there is any opportunities, I'd be more than curious to discuss what kind of test/framework you use to test data integrity in your databases, as we are facing similar issues in my organization!

Thanks again for your time @dimus!

@dimus
Copy link
Member

dimus commented Jan 10, 2025

Yes, lets close this one, and I will create a new issue. gnverifier and its components are written in Go, so I use Go HTTP testing framework for RESTful tests, for example https://github.com/gnames/gnames/blob/master/internal/io/rest/bug_test.go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants