This repository has been archived by the owner on Nov 30, 2022. It is now read-only.
Replies: 1 comment 5 replies
-
Interesting, oversight by me, everything in the ShopModel trait should reference an interface. I can update this. |
Beta Was this translation helpful? Give feedback.
5 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
@osiset
In
Osiset\ShopifyApp\Contracts\ShopModel
interfacegetShopId()
method expecting theOsiset\ShopifyApp\Objects\Values\ShopId
object as return type. But this object can be only integer type inside.And UUID can not be used as ID value.
I think the best solution - use inside
Osiset\ShopifyApp\Contracts\ShopModel
interfaceShopId
interface.For example
Osiset\ShopifyApp\Contracts\ShopId
. This will give possible to create own implementation ofShopId
Beta Was this translation helpful? Give feedback.
All reactions