Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove gtk-update-icon-cache handling in setup #102

Closed
lazyfrosch opened this issue May 21, 2020 · 1 comment · Fixed by #493
Closed

Remove gtk-update-icon-cache handling in setup #102

lazyfrosch opened this issue May 21, 2020 · 1 comment · Fixed by #493
Labels
quality This that should be improved but aren't a bug or feature

Comments

@lazyfrosch
Copy link
Member

lazyfrosch commented May 21, 2020 •
edited
Loading

I don't see a reason why we should generate the cache like this, its even bad for packages. So (package) maintainers should disable it.

Debian:
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=959856
@lazyfrosch lazyfrosch added the quality This that should be improved but aren't a bug or feature label May 21, 2020
@lazyfrosch lazyfrosch added this to the 2.0 milestone May 21, 2020
@mattrose
Copy link
Member

Just noticed this hasn't been touched in a while and I'd like to get ready to release 2.0. I'm going to remove the 2.0 milestone. In the rpm manifest we just remove the icon-cache file.

@mattrose mattrose removed this from the 2.0 milestone Aug 23, 2020
@mattrose mattrose mentioned this issue Aug 24, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
quality This that should be improved but aren't a bug or feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

remove gtk-update-icon-cache from setup.py mattrose/terminator
2 participants
@mattrose @lazyfrosch