Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Command-line option to unhide previously hidden Terminator #304

Closed
UnsolvedCypher opened this issue Nov 23, 2020 · 7 comments · Fixed by #307
Closed

Command-line option to unhide previously hidden Terminator #304

UnsolvedCypher opened this issue Nov 23, 2020 · 7 comments · Fixed by #307
Labels
question Further information is requested

Comments

@UnsolvedCypher
Copy link

In Wayland, applications cannot register global hotkeys, so once the Terminator window gets hidden with the "hide window" hotkey, it cannot be unhidden with a hotkey. For Guake, I can bind a shortcut to guake -t in my desktop environment which will unhide a previously hidden window, and I would like to do something similar in Terminator. Otherwise, the hiding functionality is unusable on Wayland.

@mattrose
Copy link
Member

That is a great idea. I knew that this was a problem on Wayland and I've been desparately trying to think of a way to fix that, and this is just the idea I needed.

@mattrose
Copy link
Member

@UnsolvedCypher would you mind trying out the PR attached to this issue?

@mattrose mattrose added the question Further information is requested label Nov 26, 2020
@UnsolvedCypher
Copy link
Author

UnsolvedCypher commented Nov 27, 2020

@mattrose Thank you for very quickly coming up with a PR! The hiding functionality does not seem to be working for me in the first place (I set the hide keybinding and it does not hide, and I have tried a number of different keybindings). Is there some additional information I can provide? Logs or something?

@mattrose
Copy link
Member

If you have a fresh config it should be Ctrl-Alt-A, there's some weirdness in that code to do with stripping the shift key that I don't understand. If you run terminator on the command line it should be able to tell you if it was able to bind the key or not.

@UnsolvedCypher
Copy link
Author

Hmm when I run terminator on the command line I don't see any output on startup (this is with a clean config).

@mattrose
Copy link
Member

Does it hide now when you hit Ctrl-Alt-A?

When it's unable to bind it usually spits out Unable to bind hide_window key, another instance/window has it.

Did you bind the same key combo to your window manager for unhiding?

@mattrose
Copy link
Member

mattrose commented Dec 1, 2020

This works for me, I'm just gonna merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants