Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch focus and splits don't work when terminal is zoomed #550

Closed
Felixoid opened this issue Dec 7, 2021 · 1 comment · Fixed by #553
Closed

Switch focus and splits don't work when terminal is zoomed #550

Felixoid opened this issue Dec 7, 2021 · 1 comment · Fixed by #553

Comments

@Felixoid
Copy link

Felixoid commented Dec 7, 2021

Is your feature request related to a problem? Please describe.
When a tab has few terminals and one is zoomed, switching to any direction doesn't work. There are different approaches in different emulators:

  • tmux cancels zoom and switch to another pane
  • kitty remains zoomed, but switch the pane to the next/previous one

Describe the solution you'd like
I'd prefer tmux approach, when focus change is triggered, it's better to zoom out the current terminal and then switch

Describe alternatives you've considered
Kitty's approach would work as well. The zoom can be preserved during a terminal focus switch

update: the same case is for splits. It seems logical to me to exit zoom mode and split terminal. And the same for tab switching.

@Felixoid Felixoid changed the title Switch focus when terminal is zoomed Switch focus and splits don't work when terminal is zoomed Dec 8, 2021
@Vulcalien
Copy link
Member

Vulcalien commented Dec 8, 2021

I'm working on this. I've implemented a surprisingly clean solution for splits and new tabs. Still working on the 'switch to tab' thing.

As a side note: un-zooming a terminal when there are tabs, makes the background opaque.

Thanks again for the bug report.

Edit: also, the 'move to another terminal' event.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants