Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

429 Too Many Requests Rate Limit Error #390

Closed
RBeaudoin opened this issue Apr 28, 2017 · 11 comments
Closed

429 Too Many Requests Rate Limit Error #390

RBeaudoin opened this issue Apr 28, 2017 · 11 comments

Comments

@RBeaudoin
Copy link

RBeaudoin commented Apr 28, 2017

At Heroku, we've been seeing the following frequently in our error logs:

acme: Error 429 - - <html> <head><title>429 Too Many Requests</title></head> <body bgcolor="white"> <center><h1>429 Too Many Requests</h1></center> <hr><center>nginx</center> </body> </html> 

My understanding after speaking with LE is that this is the Overall Rate limit of 20 reqs/second.

We had hoped that ee0018c and 45beff7 would address this issue, but there still seems to be a problem.

CC @jsha

@jsha
Copy link
Contributor

jsha commented Apr 29, 2017

A quick look at the logs shows that you do seem to successfully stay under 20 reqs/second in general. How many times per day do you get this error? Can you share the IP addresses from which you get it?

@RBeaudoin
Copy link
Author

@jsha thanks for looking into this, we are seeing this 2-3 times a day in production.

Unfortunately, that is the only information we get back in the error so I won't be able to provide the IP addresses.

@jsha
Copy link
Contributor

jsha commented May 2, 2017

If it's only 2-3 times a day, I wouldn't worry about it too much. It could be slight differences between xenolf/lego's internal rate limiting implementation and how we count rate limits on the server side. If you see an increase, please let us know!

@RBeaudoin
Copy link
Author

We're now seeing it 7-9 times a day the past two days.

@trecloux
Copy link
Contributor

trecloux commented May 3, 2017

@jsha I can easily trigger it on staging with a fixed IP, could it be useful for you ?

@jsha
Copy link
Contributor

jsha commented May 3, 2017

Yeah, that would! Especially if you can provide a little Go script that triggers it.

@RBeaudoin
Copy link
Author

Anything we can do to help with this... still seeing a fair amount of 429 errors and would love to help clear these up.

@jsha
Copy link
Contributor

jsha commented May 15, 2017

We're still working on diagnosing this, thanks for the update that it's still causing you issues!

@jsha
Copy link
Contributor

jsha commented May 17, 2017

I believe we've fixed this server-side: https://community.letsencrypt.org/t/html-style-rate-limit-responses/34146.

@jsha
Copy link
Contributor

jsha commented Jun 30, 2017

Proposing to close this. What do you all think?

@xenolf
Copy link
Member

xenolf commented Jul 13, 2017

I think we can. If someone encounters this problem again please open a new issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

4 participants