-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: sleep at renewal #1657
feat: sleep at renewal #1657
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've found some defects :)
Co-authored-by: Dominik Menke <[email protected]>
454f58c
to
f1fe9cd
Compare
@ldez, I have another remark: @jsha asked for a randomized sleep for non-interactive renewal. The current implementation however requires an extra flag to skip it. Users might be surprised when they run Wouldn't it be better, if we (additionally) check if !isatty.IsTerminal(os.Stdout.Fd()) && !ctx.Bool("no-random-sleep") {
// ...
} (N.B.: This is the same approach certbot uses)
If we don't want to use that, the What do you think, shall I open a PR? |
@dmke you can open a PR. For the problem with go1.18 we already use an updated version of |
Add a sleep between 0 to 8 minutes during the call of the
renew
command like certbot.Fixes #1656