Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Token for trigger mirror-sync only #13656

Closed
1 of 4 tasks
wenerme opened this issue Nov 20, 2020 · 1 comment
Closed
1 of 4 tasks

Token for trigger mirror-sync only #13656

wenerme opened this issue Nov 20, 2020 · 1 comment
Labels
issue/duplicate The issue has already been reported.

Comments

@wenerme
Copy link

wenerme commented Nov 20, 2020

  • Gitea version (or commit ref): 1.14.0+dev-239-gad2a28862

  • Git version: 1.14.0+dev

  • Operating system: Linux/Docker

  • Database (use [x]):

    • PostgreSQL
    • MySQL
    • MSSQL
    • SQLite

Description

User can read repo, but can not trigger https://git.my.org/api/v1/repos/my/repo/mirror-sync?token=$TOKEN, this is used in the webhook of other system like gitlab, github. Webhook is not hide in most system, this cause the owner's PAT is leaked to who can access the webhook, which is quite common allowed a lot user to access. Better to have a token only for mirror-sync or provide another webhook url which not require token.

BTW, gitlab has a lot token for various actions, like feed token or email token, this can prevent leak the pat.

@jolheiser
Copy link
Member

I think this is closely enough related to #4300 to close this one in favor of the other with more details.

@jolheiser jolheiser added the issue/duplicate The issue has already been reported. label Nov 20, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Jan 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
issue/duplicate The issue has already been reported.
Projects
None yet
Development

No branches or pull requests

2 participants