Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

incorrect redirect when proposing file change with # in branch name #14355

Closed
1 task done
jpraet opened this issue Jan 16, 2021 · 0 comments · Fixed by #14364
Closed
1 task done

incorrect redirect when proposing file change with # in branch name #14355

jpraet opened this issue Jan 16, 2021 · 0 comments · Fixed by #14364
Labels
type/bug
Milestone
1.14.0

Comments

@jpraet
Copy link
Member

jpraet commented Jan 16, 2021

Description

When modifying a file through the web UI via a pull request, if you have a # in the branch name you get a 404.

Screenshots

image

image

The # should get URL encoded:

image
@jpraet jpraet mentioned this issue Jan 17, 2021
Merged
@lafriks lafriks added this to the 1.14.0 milestone Jan 17, 2021
@go-gitea go-gitea locked and limited conversation to collaborators Mar 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type/bug
Projects
None yet
Milestone
1.14.0
Development

Successfully merging a pull request may close this issue.

escape branch names in compare url jpraet/gitea
2 participants
@lafriks @jpraet