Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When Creating an Issue, Attachments that are Added and then Removed are Still Attached #22731

Closed
russoj88 opened this issue Feb 2, 2023 · 6 comments
Labels
issue/needs-feedback For bugs, we need more details. For features, the feature must be described in more detail issue/not-a-bug The reported issue is the intended behavior or the problem is not inside Gitea

Comments

@russoj88
Copy link

russoj88 commented Feb 2, 2023

Description

When creating an issue, attachments that are added and then removed are still attached. Steps to reproduce.

  1. Create a new issue.
  2. Add an attachment (copy, paste from filesystem). This automatically adds an attachment to the issue and then puts the proper markdown link in the text.
  3. Remove the generated text.
  4. See that the attachment is still attached.

Gitea Version

19.0+dev-415-g82728a7ce

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

No response

Screenshots

1
2
3

Git Version

No response

Operating System

No response

How are you running Gitea?

https://try.gitea.io/

Database

None

@a1012112796
Copy link
Member

you should remove it manually and save the comment, example:
tt

@a1012112796 a1012112796 added the issue/not-a-bug The reported issue is the intended behavior or the problem is not inside Gitea label Feb 3, 2023
@russoj88
Copy link
Author

russoj88 commented Feb 3, 2023

Thanks for the reply. I'm of course not the one to decide behavior, but I don't think this is good. It's unexpected to have to "remove" the attachment twice.

@a1012112796
Copy link
Member

It's unexpected to have to "remove" the attachment twice.

Hmm, firstly It's a hard job to check if it's link is exist in the contant, then although it's link not exist in the content, it's also can be a part of comment like other file types.

@russoj88
Copy link
Author

russoj88 commented Feb 9, 2023

When adding an attachment through a comment, could we get someway to know it's there, and then remove it?

@lunny lunny added issue/needs-feedback For bugs, we need more details. For features, the feature must be described in more detail and removed type/bug labels May 31, 2023
@lunny
Copy link
Member

lunny commented May 31, 2023

It's really unnecessary to parse the comment content to detect whether the attachments have been removed.

@GiteaBot
Copy link
Collaborator

GiteaBot commented Sep 8, 2023

We close issues that need feedback from the author if there were no new comments for a month. 🍵

@GiteaBot GiteaBot closed this as completed Sep 8, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
issue/needs-feedback For bugs, we need more details. For features, the feature must be described in more detail issue/not-a-bug The reported issue is the intended behavior or the problem is not inside Gitea
Projects
None yet
Development

No branches or pull requests

4 participants