Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compare release with other tagged versions not working #22737

Closed
kernie opened this issue Feb 3, 2023 · 5 comments
Closed

Compare release with other tagged versions not working #22737

kernie opened this issue Feb 3, 2023 · 5 comments
Labels
issue/needs-feedback For bugs, we need more details. For features, the feature must be described in more detail

Comments

@kernie
Copy link
Contributor

kernie commented Feb 3, 2023

Description

Following scenario:

  • Create a repo
  • Commit und push something, create a tag, create a release in Gitea
  • Commit und push something, create a second tag
  • Go to the gitea web page -> Releases
  • Choose the one release
  • Click "Compare" with the second tag

It results in "No common commits. The tagged versions do not share a common history" (translated, I have it in German).

The link not working is: https://try.gitea.io/koobiedoodiedoo/TagCompare/compare/Rev01...Rev00

However, https://try.gitea.io/koobiedoodiedoo/TagCompare/compare/Rev00...Rev01 works as expected.

Gitea Version

1.19.0+dev-415-g82728a7ce, 1.18.3

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

No response

Screenshots

grafik

Git Version

No response

Operating System

Ubuntu 20.04

How are you running Gitea?

mysql DB, systemd, on virtual machine

Database

MySQL

@kernie kernie added the type/bug label Feb 3, 2023
@delvh
Copy link
Member

delvh commented Feb 3, 2023

Please click on the PR icon you see on the top left of the page, this should turn the comparison around.

@delvh delvh added issue/needs-feedback For bugs, we need more details. For features, the feature must be described in more detail and removed type/bug labels Feb 3, 2023
@delvh
Copy link
Member

delvh commented Feb 3, 2023

The only thing we could think about is whether we swap around the comparison by default.
I'm not sure if the current approach, or the opposite is the correct comparison.

@kernie
Copy link
Contributor Author

kernie commented Feb 3, 2023

@delvh thanks for the hint with the symbol. I'm not a git expert, your answer implies that the forward comparison old<->new isn't possible at all? Only new<-> old?

@delvh
Copy link
Member

delvh commented Feb 3, 2023

I don't think it is.
As I mentioned, I'm not too familiar with the comparison mechanism, since we simply pass it down to git which handles that itself.
The problem is even more difficult as there are in total four different possibilities:
In addition to reversing the comparison, there is also a different comparing mechanism you can unlock by clicking on the in your screenshot.
I always get confused which one will be correct, and simply try all combinations until I find the one that looks probable.

@GiteaBot
Copy link
Collaborator

GiteaBot commented Sep 8, 2023

We close issues that need feedback from the author if there were no new comments for a month. 🍵

@GiteaBot GiteaBot closed this as completed Sep 8, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
issue/needs-feedback For bugs, we need more details. For features, the feature must be described in more detail
Projects
None yet
Development

No branches or pull requests

3 participants