Branch protection, can still be pushed #24373

ghostman-git · 2023-04-27T04:51:03Z

Description

Branch protection, can still be pushed

Gitea Version

1.19.1

Can you reproduce the bug on the Gitea demo site?

No

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

docker

How are you running Gitea?

docker

Database

MySQL

wxiaoguang · 2023-04-27T05:54:38Z

Are you admin?

ghostman-git · 2023-04-27T06:45:11Z

Are you admin?

yes

wxiaoguang · 2023-04-27T06:55:48Z

Are you admin?

yes

~~yes, so you can bypass that rule. That's by design.~~

Update: maybe I read it wrong.

lunny · 2023-04-27T07:00:39Z

I cannot reproduce that.

I don't think the site admin can bypass that rule.

ghostman-git · 2023-04-27T07:18:22Z

我无法重现这一点。

我认为网站管理员无法绕过该规则。

你是管理员吗？

是的

~~是的，所以你可以绕过这条规则。这是设计使然。~~

更新：也许我看错了。

Are you admin?

yes

~~yes, so you can bypass that rule. That's by design.~~

Update: maybe I read it wrong.

Upgrade from previous version to v1.19.1

ghostman-git · 2023-04-27T07:18:30Z

I cannot reproduce that.

I don't think the site admin can bypass that rule.

Upgrade from previous version to v1.19.1

wxiaoguang · 2023-04-27T07:40:05Z

What's your app.ini config / local git repo config (remote) / push command? and what's the response?

And one more question, can you reproduce it with a new / clear installation?

ghostman-git · 2023-04-28T01:10:20Z

What's your app.ini config / local git repo config (remote) / push command? and what's the response?

And one more question, can you reproduce it with a new / clear installation?

app.ini

APP_NAME = Gitea: Git with a cup of tea
RUN_MODE = prod
RUN_USER = git

[repository]
ROOT = /data/git/repositories

[repository.local]
LOCAL_COPY_PATH = /data/gitea/tmp/local-repo

[repository.upload]
TEMP_PATH = /data/gitea/uploads

[server]
APP_DATA_PATH    = /data/gitea
DOMAIN           = 192.168.31.244
SSH_DOMAIN       = 192.168.31.244
HTTP_PORT        = 3000
ROOT_URL         = http://192.168.31.244:3000/
DISABLE_SSH      = false
SSH_PORT         = 22
SSH_LISTEN_PORT  = 22
LFS_START_SERVER = true
LFS_CONTENT_PATH = /data/git/lfs
LFS_JWT_SECRET   = 123
OFFLINE_MODE     = true

[database]
PATH     = /data/gitea/gitea.db
DB_TYPE  = mysql
HOST     = localhost:3306
NAME     = gitea
USER     = ****
PASSWD   = ****
LOG_SQL  = false
SCHEMA   = 
SSL_MODE = disable
CHARSET  = utf8mb4

[indexer]
ISSUE_INDEXER_PATH = /data/gitea/indexers/issues.bleve

[session]
PROVIDER_CONFIG = /data/gitea/sessions
PROVIDER        = file

[picture]
AVATAR_UPLOAD_PATH            = /data/gitea/avatars
REPOSITORY_AVATAR_UPLOAD_PATH = /data/gitea/repo-avatars
DISABLE_GRAVATAR              = true
ENABLE_FEDERATED_AVATAR       = false

[attachment]
MAX_SIZE      = 3072
ALLOWED_TYPES = */*
PATH          = /data/gitea/attachments

[log]
ROOT_PATH        = /data/gitea/log
MODE             = file
LEVEL            = info
ROUTER           = file
ROUTER_LOG_LEVEL = file

[security]
INSTALL_LOCK        = true
SECRET_KEY          = 123
INTERNAL_TOKEN      = 123
PASSWORD_COMPLEXITY = off

[service]
DISABLE_REGISTRATION              = true
REQUIRE_SIGNIN_VIEW               = true
REGISTER_EMAIL_CONFIRM            = false
ENABLE_NOTIFY_MAIL                = true
ALLOW_ONLY_EXTERNAL_REGISTRATION  = false
ENABLE_CAPTCHA                    = false
DEFAULT_KEEP_EMAIL_PRIVATE        = false
DEFAULT_ALLOW_CREATE_ORGANIZATION = true
DEFAULT_ENABLE_TIMETRACKING       = true
NO_REPLY_ADDRESS                  = noreply.localhost

[oauth2]
JWT_SECRET = 123

[mailer]
ENABLED = true
HOST    = smtp.exmail.qq.com:465
FROM    = [email protected]
USER    = [email protected]
PASSWD  = ****

[openid]
ENABLE_OPENID_SIGNIN = false
ENABLE_OPENID_SIGNUP = false

git push

git push upstream/dev

Not tested yet, deploying testing

wxiaoguang · 2023-05-10T05:36:50Z

Not tested yet, deploying testing

Any progress?

ghostman-git · 2023-05-11T07:12:42Z

Not tested yet, deploying testing

Any progress?

The latest version is fine, but the upgrade from the original version will not work.

lunny · 2023-05-11T07:22:47Z

Could you run ./gitea doctor?

wxiaoguang · 2023-05-11T07:36:56Z

The latest version is fine, but the upgrade from the original version will not work.

If you create a new repo in your old instance, does its branch protection work?

ghostman-git · 2023-05-12T08:20:27Z

The latest version is fine, but the upgrade from the original version will not work.

If you create a new repo in your old instance, does its branch protection work?

Tried, invalid

ghostman-git · 2023-05-12T08:33:19Z

Could you run ?./gitea doctor

How to run？

./gitea doctor

wxiaoguang · 2023-05-12T09:13:32Z

The latest version is fine, but the upgrade from the original version will not work.

If you create a new repo in your old instance, does its branch protection work?

Tried, invalid

If you have tried gitea doctor and tried the newly create repo, the same problem still exists, from my side I do not have idea for this problem at the moment. It looks like something is out of sync, but it seems need some deep debugging work on your instance.

ps: does protection work for the push over https (not ssh)? if https works, then the problem is highly likely related the ssh part.

ghostman-git · 2023-05-15T05:38:16Z

The latest version is fine, but the upgrade from the original version will not work.

If you create a new repo in your old instance, does its branch protection work?

Tried, invalid

If you have tried and tried the newly create repo, the same problem still exists, from my side I do not have idea for this problem at the moment. It looks like something is out of sync, but it seems need some deep debugging work on your instance.gitea doctor

ps: does protection work for the push over https (not ssh)? if https works, then the problem is highly likely related the ssh part.

Use http, invalid

ghostman-git · 2023-05-15T05:51:15Z

The latest version is fine, but the upgrade from the original version will not work.

If you create a new repo in your old instance, does its branch protection work?

Tried, invalid

If you have tried and tried the newly create repo, the same problem still exists, from my side I do not have idea for this problem at the moment. It looks like something is out of sync, but it seems need some deep debugging work on your instance.gitea doctor

ps: does protection work for the push over https (not ssh)? if https works, then the problem is highly likely related the ssh part.

There are some warnings about data table columns in the log at startup, I don't know if it affects it

lunny · 2023-05-16T09:16:13Z

Those logs will not affect anything.

ghostman-git · 2023-05-17T03:34:56Z

gwynlionhart · 2023-06-06T15:59:19Z

I am having the same issue with Gitea version 1.19.3. Using docker.

Initialize Gitea as some admin user "admin"
Create an organization "org"
Create a Team "team" in that organization with write permissions to Code
Create a user and put them in the "team" Team.
Create a repository "test" in that organization and initialize the "main" branch
Go to the repo setting, then Branches, then Add New Rule for branch protection
Set Protected Branch Pattern to "main"
Disable Push
Required approvals:1
Block merge on rejected reviews
Save Rule
Clone the repo as the test user
Edit the readme file, commit it
git push
See below output of the git push

user@workstation MINGW64 ~/projects/test (main)
$ git push
Enumerating objects: 5, done.
Counting objects: 100% (5/5), done.
Writing objects: 100% (3/3), 253 bytes | 253.00 KiB/s, done.
Total 3 (delta 0), reused 0 (delta 0), pack-reused 0
To https://git-website.com/git/org/test.git
   ea12f0d..54c30fa  main -> main

Zettat123 · 2023-06-09T03:59:37Z

Upgrade from previous version to v1.19.1

Which version did you upgrade to v1.19.1 from?

ghostman-git · 2023-06-10T09:32:36Z

Upgrade from previous version to v1.19.1

Which version did you upgrade to v1.19.1 from?

It may be gradually upgraded from v1.14.8, basically every version will be upgraded, but it is not clear which version to start from. This can be used well.

GiteaBot · 2023-09-08T13:20:42Z

We close issues that need feedback from the author if there were no new comments for a month. 🍵

ghostman-git added the type/bug label Apr 27, 2023

wxiaoguang added issue/needs-feedback For bugs, we need more details. For features, the feature must be described in more detail and removed type/bug labels Apr 27, 2023

yardenshoham mentioned this issue Sep 8, 2023

Close issues with status/needs-feedback that were last updated more than a month ago GiteaBot/gitea-backporter#108

Merged

GiteaBot closed this as completed Sep 8, 2023

github-actions bot locked as resolved and limited conversation to collaborators Oct 24, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Branch protection, can still be pushed #24373

Branch protection, can still be pushed #24373

ghostman-git commented Apr 27, 2023

wxiaoguang commented Apr 27, 2023

ghostman-git commented Apr 27, 2023

wxiaoguang commented Apr 27, 2023 •

edited

Loading

lunny commented Apr 27, 2023

ghostman-git commented Apr 27, 2023

ghostman-git commented Apr 27, 2023

wxiaoguang commented Apr 27, 2023 •

edited

Loading

ghostman-git commented Apr 28, 2023

wxiaoguang commented May 10, 2023

ghostman-git commented May 11, 2023

lunny commented May 11, 2023

wxiaoguang commented May 11, 2023

ghostman-git commented May 12, 2023

ghostman-git commented May 12, 2023

wxiaoguang commented May 12, 2023 •

edited

Loading

ghostman-git commented May 15, 2023

ghostman-git commented May 15, 2023

lunny commented May 16, 2023

ghostman-git commented May 17, 2023

gwynlionhart commented Jun 6, 2023

Zettat123 commented Jun 9, 2023

ghostman-git commented Jun 10, 2023

GiteaBot commented Sep 8, 2023

Branch protection, can still be pushed #24373

Branch protection, can still be pushed #24373

Comments

ghostman-git commented Apr 27, 2023

Description

Gitea Version

Can you reproduce the bug on the Gitea demo site?

Log Gist

Screenshots

Git Version

Operating System

How are you running Gitea?

Database

wxiaoguang commented Apr 27, 2023

ghostman-git commented Apr 27, 2023

wxiaoguang commented Apr 27, 2023 • edited Loading

lunny commented Apr 27, 2023

ghostman-git commented Apr 27, 2023

ghostman-git commented Apr 27, 2023

wxiaoguang commented Apr 27, 2023 • edited Loading

ghostman-git commented Apr 28, 2023

wxiaoguang commented May 10, 2023

ghostman-git commented May 11, 2023

lunny commented May 11, 2023

wxiaoguang commented May 11, 2023

ghostman-git commented May 12, 2023

ghostman-git commented May 12, 2023

wxiaoguang commented May 12, 2023 • edited Loading

ghostman-git commented May 15, 2023

ghostman-git commented May 15, 2023

lunny commented May 16, 2023

ghostman-git commented May 17, 2023

gwynlionhart commented Jun 6, 2023

Zettat123 commented Jun 9, 2023

ghostman-git commented Jun 10, 2023

GiteaBot commented Sep 8, 2023

wxiaoguang commented Apr 27, 2023 •

edited

Loading

wxiaoguang commented Apr 27, 2023 •

edited

Loading

wxiaoguang commented May 12, 2023 •

edited

Loading