Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow admin to delete user keys via API #3014

Closed
2 of 7 tasks
vtemian opened this issue Nov 28, 2017 · 0 comments
Closed
2 of 7 tasks

Allow admin to delete user keys via API #3014

vtemian opened this issue Nov 28, 2017 · 0 comments
Labels
modifies/api This PR adds API routes or modifies them
Milestone

Comments

@vtemian
Copy link
Contributor

vtemian commented Nov 28, 2017

  • Gitea version (or commit ref): 6ad4990
  • Git version: 2.7.4
  • Operating system: Ubuntu 16.04
  • Database (use [x]):
    • PostgreSQL
    • MySQL
    • MSSQL
    • SQLite
  • Can you reproduce the bug at https://try.gitea.io:
    • Yes (provide example URL)
    • No
    • Not relevant
  • Log gist:

Description

Right now, admins can create keys on behalf of an user, but they can't delete them. (via API)
I suggest that we also support the DELETE operation.

From a bigger perspective, is there any reason why the /user endpoints where implemented instead of /users/{username}? (I guess they were already implemented in gogs)

It's easier for an admin to manage it's users via /users/{username}. It can introduce some overhead and confusion if for each resource type endpoint will exist an equivalent admin endpoint (DELETE: /users/{username}/keys/{id} -> /admin/users/{username}/keys/{id}).

@lunny lunny added the type/proposal The new feature has not been accepted yet but needs to be discussed first. label Nov 29, 2017
@lafriks lafriks closed this as completed in 469ab99 Dec 6, 2017
@lafriks lafriks added this to the 1.4.0 milestone Dec 6, 2017
@lafriks lafriks added type/feature Completely new functionality. Can only be merged if feature freeze is not active. modifies/api This PR adds API routes or modifies them and removed type/proposal The new feature has not been accepted yet but needs to be discussed first. type/feature Completely new functionality. Can only be merged if feature freeze is not active. labels Dec 6, 2017
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
modifies/api This PR adds API routes or modifies them
Projects
None yet
Development

No branches or pull requests

3 participants