HTTP Error 500 when publishing openid url

[simmstein]

• Gitea version (or commit ref): 1.5.0
• Git version: 2.1.14
• Operating system: Debian GNU/Linux Jessie
• Database:
  • PostgreSQL
  • MySQL (5.5.60-0+deb8u1)
  • MSSQL
  • SQLite
• Can you reproduce the bug at https://try.gitea.io:
  • Yes (provide example URL)
  • No
  • Not relevant
• Log gist:

2018/10/18 16:26:18 [I] [SQL] update user_open_id set show = not show where id = ? []interface {}{3}
2018/10/18 16:26:18 [...g/security_openid.go:120 ToggleOpenIDVisibility()] [E] ToggleUserOpenIDVisibility: Error 1064: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'show = not show where id = ?' at line 1

Description

After I added my OpenID access using my configuration panel (Profil / Configuration / Security), I wanted to publish on my public profile the OpenID URL. After clicking on the button, I see a HTTP Error 500.

Screenshots

[filipnavara]

Hmm, seems to be issue with "show" being a keyword in MySQL and not being quoted in the SQL syntax.

[filipnavara]

I guess changing this line:

gitea/models/user_openid.go

Line 96 in 801843b

_, err = x.Exec("update user_open_id set show = not show where id = ?", id)

to something like x.Exec("update user_open_id set \"show\" = not \"show\" where id = ?", id) should help.

[strk]

Filip can you try sending a PR with this change ? I'll be happy to review, I love OpenID-2.0 users ! :)

[filipnavara]

@strk I will be happy to submit a PR, but I cannot test it properly since I don't have MySQL setup at the moment.

[strk]

On Thu, Oct 18, 2018 at 06:32:43PM +0000, Filip Navara wrote: @strk I will be happy to submit a PR, but I cannot test it properly since I don't have MySQL setup at the moment.

There are integrations tests running as part of the testsuite, maybe you could try to add tests for OpenID usage ? (challenging task, mind you!)

[strk]

also I guess @simmstein would be up to test your PR ?

[simmstein]

Of course! I just need a binary beause it's the way I choose to use gitea.