Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: rename "Reject" to "Request changes" (or similar) #5857

Closed
InExtremaRes opened this issue Jan 26, 2019 · 0 comments · Fixed by #5858
Closed

Suggestion: rename "Reject" to "Request changes" (or similar) #5857

InExtremaRes opened this issue Jan 26, 2019 · 0 comments · Fixed by #5858
Milestone

Comments

@InExtremaRes
Copy link

  • Gitea version (or commit ref): d663930
    (rest is irrelevant)

Description

When reviewing a PR you can "Approve" or "Reject". The problem is that "Reject" sound too hard/rude and can hurt team relationship and confidence. Most of the time the PR is almost good but you are requesting some changes before merging, not rejecting the PR itself. GitHub, as an example, shows "Request changes" instead and I think it's a better name.

So, consider rename the "Reject" button and the "Someone rejected these changes" text to something like "Request changes" and "Someone requested changes".

@lunny lunny added this to the 1.8.0 milestone Feb 6, 2019
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants