You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Gitea version (or commit ref): d663930
(rest is irrelevant)
Description
When reviewing a PR you can "Approve" or "Reject". The problem is that "Reject" sound too hard/rude and can hurt team relationship and confidence. Most of the time the PR is almost good but you are requesting some changes before merging, not rejecting the PR itself. GitHub, as an example, shows "Request changes" instead and I think it's a better name.
So, consider rename the "Reject" button and the "Someone rejected these changes" text to something like "Request changes" and "Someone requested changes".
The text was updated successfully, but these errors were encountered:
(rest is irrelevant)
Description
When reviewing a PR you can "Approve" or "Reject". The problem is that "Reject" sound too hard/rude and can hurt team relationship and confidence. Most of the time the PR is almost good but you are requesting some changes before merging, not rejecting the PR itself. GitHub, as an example, shows "Request changes" instead and I think it's a better name.
So, consider rename the "Reject" button and the "Someone rejected these changes" text to something like "Request changes" and "Someone requested changes".
The text was updated successfully, but these errors were encountered: