Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: add pagination and sort on Issue Comments API #6132

Open
meteorlxy opened this issue Feb 20, 2019 · 4 comments
Open

Feature Request: add pagination and sort on Issue Comments API #6132

meteorlxy opened this issue Feb 20, 2019 · 4 comments
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented modifies/api This PR adds API routes or modifies them type/enhancement An improvement of existing functionality

Comments

@meteorlxy
Copy link

meteorlxy commented Feb 20, 2019

Description

I'm developing a project to get/post comments via the issue system.

Hope gitea can support these features (with some info of other platform):

  • Pagination
    • Github: use universal pagination - REF - only have Link header, which lacks useful infomation
    • Gitlab: use universal pagination - REF - have other pagination headers besides Link header, which provide all the related information of pagination
    • Bitbucker: use universal pagination - REF - do not have headers
  • Sorting comments:
    • Github: only accpet since param on issue comments API, similar to current version of gitea - REF - (I've sent feedback to Github but they said they might not fix it in the near future)
    • Gitlab: use params sort, order_by - REF
    • Bitbucket: use universal filtering and sorting - REF1 - REF2
@lunny lunny added the type/enhancement An improvement of existing functionality label Feb 20, 2019
@stale
Copy link

stale bot commented Apr 21, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.

@stale stale bot added the issue/stale label Apr 21, 2019
@lunny lunny added modifies/api This PR adds API routes or modifies them issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented labels Apr 21, 2019
@stale stale bot removed the issue/stale label Apr 21, 2019
@6543
Copy link
Member

6543 commented Apr 10, 2020

@meteorlxy paggination for IssueComments will be in v1.12
look at the demo: https://try.gitea.io/api/swagger#/issue/issueGetRepoComments

@lunny
Copy link
Member

lunny commented Sep 3, 2020

So only sort is absent on this issue?

@noerw
Copy link
Member

noerw commented Dec 16, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented modifies/api This PR adds API routes or modifies them type/enhancement An improvement of existing functionality
Projects
None yet
Development

No branches or pull requests

4 participants