Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Will PR merge in 1GB+ repo be slow? #6287

Closed
2 of 7 tasks
yanOnGithub opened this issue Mar 8, 2019 · 6 comments
Closed
2 of 7 tasks

Will PR merge in 1GB+ repo be slow? #6287

yanOnGithub opened this issue Mar 8, 2019 · 6 comments
Labels
type/question Issue needs no code to be fixed, only a description on how to fix it yourself.

Comments

@yanOnGithub
Copy link

yanOnGithub commented Mar 8, 2019

  • Gitea version (or commit ref): 1.7.3
  • Git version: git version 2.20.1.windows.1
  • Operating system: windows 10 or 2012
  • Database (use [x]):
    • PostgreSQL
    • MySQL
    • MSSQL
    • SQLite
  • Can you reproduce the bug at https://try.gitea.io:
    • Yes (provide example URL)
    • No
    • Not relevant
  • Log gist:

Description

According to #6003 (comment)

When the Gitea Server performs a merge, it checks out your repository into a temporary location, runs git merge and then git pushes the new commit back into the main repository:

My repo is 1 GB+ in size. What is the expected run time of a PR and merge? Will it involve a 1GB+ git checkout? The server is probably on 7200rpm spinning disk. I have yet to try it.

@techknowlogick techknowlogick added the type/question Issue needs no code to be fixed, only a description on how to fix it yourself. label Mar 9, 2019
@yanOnGithub
Copy link
Author

I have just tested it. It took 39 sec to merge a PR on my 1GB repo. In windows resource monitor, I noticed disk activity to the gitea/data/tmp/local-repo/merge-XXXXXXX folder during the merge. The checkout is done lazily/on-demand. Can a clone or checkout be done in advance before the merge?

@yanOnGithub
Copy link
Author

Ideally the run time of the merge should be proportional to the size of the change but not the size of the repo. I have a few GB of disk space to spare.

@zeripath
Copy link
Contributor

zeripath commented Mar 9, 2019

@yanOnGithub I think there are a few more speed improvements possible with the merging of pull requests however, it should be much better than on older versions of gitea.

Can I ask you to try to use the web editor or upload - the technique used in that code is almost the fastest I can think of without doing in memory index files.

@yanOnGithub
Copy link
Author

#601 is closed in milestone 1.8.0. Let me try it after 2019 Mar 25

https://github.com/go-gitea/gitea/milestone/32?closed=1

@yanOnGithub
Copy link
Author

What are web editor or upload?

Can I ask you to try to use the web editor or upload - the technique used in that code is almost the fastest I can think of without doing in memory index files.

@yanOnGithub
Copy link
Author

yanOnGithub commented Apr 26, 2019

I have upgraded to 1.8.0. Merging PR completed in a few seconds. Thx.

@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type/question Issue needs no code to be fixed, only a description on how to fix it yourself.
Projects
None yet
Development

No branches or pull requests

3 participants