-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Will PR merge in 1GB+ repo be slow? #6287
Comments
I have just tested it. It took 39 sec to merge a PR on my 1GB repo. In windows resource monitor, I noticed disk activity to the gitea/data/tmp/local-repo/merge-XXXXXXX folder during the merge. The checkout is done lazily/on-demand. Can a clone or checkout be done in advance before the merge? |
Ideally the run time of the merge should be proportional to the size of the change but not the size of the repo. I have a few GB of disk space to spare. |
@yanOnGithub I think there are a few more speed improvements possible with the merging of pull requests however, it should be much better than on older versions of gitea. Can I ask you to try to use the web editor or upload - the technique used in that code is almost the fastest I can think of without doing in memory index files. |
#601 is closed in milestone 1.8.0. Let me try it after 2019 Mar 25 |
What are web editor or upload?
|
I have upgraded to 1.8.0. Merging PR completed in a few seconds. Thx. |
[x]
):Description
According to #6003 (comment)
My repo is 1 GB+ in size. What is the expected run time of a PR and merge? Will it involve a 1GB+ git checkout? The server is probably on 7200rpm spinning disk. I have yet to try it.
The text was updated successfully, but these errors were encountered: