Browsing to an uninitialized repository results in "System Notice" about editorconfig

[seanenck]

• Gitea version (or commit ref): 1.9.1
• Git version: 2.20
• Operating system: Debian buster
• Database (use [x]):
  • PostgreSQL
  • MySQL
  • MSSQL
  • SQLite
• Can you reproduce the bug at https://try.gitea.io:
  • Yes (provide example URL)
  • No (as it requires admin rights to view system notices)
  • Not relevant
• Log gist:

Description

1. I have a repository that is not initialized
2. When I browse to it in the Web UI it shows the page about being not initialized
3. This is causing a "System Notice" about editorconfig to occur in the admin panel (I believe this is a bug)

Error while getting .editorconfig file: reference not found...

[lunny]

related with #7938

[mrsdizzie]

#6478 is the commit that caused this to start happening, but the system warning code has been in middleware for years now.

What happenes in #6478 is that it changes the error in ctx.Repo.GetEditorconfig() here:

gitea/routers/repo/middlewares.go

Lines 13 to 21 in 042089f

	ec, err := ctx.Repo.GetEditorconfig()
	if err != nil && !git.IsErrNotExist(err) {
	description := fmt.Sprintf("Error while getting .editorconfig file: %v", err)
	if err := models.CreateRepositoryNotice(description); err != nil {
	ctx.ServerError("ErrCreatingReporitoryNotice", err)
	}
	return
	}

From: object does not exist [id: refs/heads/master, rel_path: ]

To: reference not found

Which then trips the !git.IsErrNotExist(err) check:

gitea/modules/git/error.go

Lines 33 to 41 in 042089f

	// IsErrNotExist if some error is ErrNotExist
	func IsErrNotExist(err error) bool {
	_, ok := err.(ErrNotExist)
	return ok
	}
	func (err ErrNotExist) Error() string {
	return fmt.Sprintf("object does not exist [id: %s, rel_path: %s]", err.ID, err.RelPath)
	}

I'm not sure if IsErrNotExist needs to be updated here as I'm not familiar with all the git plumbing code.

Separate from that, not really sure this needs to be a system notice either -- but it has been like that for years now and only recently is this check failing. Perhaps @filipnavara has more insight to the error change as they authored the commit where this started.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.

[seanenck]

This is still opened, until something changes you'll continue to see potentially confusing/untrackable System Notices about this

[WozSoftware]

Just installed 1.9.6 with MSSql and can confirm get the same issue