Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: list of URL schemes to support in markdown rendering #8490

Closed
guillep2k opened this issue Oct 13, 2019 · 2 comments · Fixed by #8496
Closed

Proposal: list of URL schemes to support in markdown rendering #8490

guillep2k opened this issue Oct 13, 2019 · 2 comments · Fixed by #8496
Labels
type/proposal The new feature has not been accepted yet but needs to be discussed first.

Comments

@guillep2k
Copy link
Member

Currently we're allowing only http and https schemes (protocols) in links rendered markdown. There are users that want others, like ftp (e.g. #8478)

Currently, this renders nothing:

[My link](ftp://www.mysite.com)

There are a number of other schemes we could support, and some of them could be very useful, like the aforementioned ftp, VS Code extensions, cvs, ed2k, torrent, git, ssh, magnet, maps, sftp, skype, svn, etc.

I'm not sure which ones could pose a security problem, so I propose adding an app.ini settings with the list of desired schemes. The obvious default is http, https, but perhaps we want to add ftp and others, so let's hear out your ideas.

@lafriks lafriks added the type/proposal The new feature has not been accepted yet but needs to be discussed first. label Oct 13, 2019
@silverwind
Copy link
Member

silverwind commented Oct 13, 2019

Seems like a good addition. mailto: is another common scheme. Does anyone have insight on what possible security concerns could be, besides obvious stuff like javascript:?

@bkmgit
Copy link
Contributor

bkmgit commented Oct 13, 2019

Link to uri schemes is helpful. Consistency with either Github or Gitlab markdown links is probably reasonable.

@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type/proposal The new feature has not been accepted yet but needs to be discussed first.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants