From cb1d7dbad1f4301d8e76d916e075d3be0bfe3180 Mon Sep 17 00:00:00 2001 From: Jason Song Date: Fri, 9 Aug 2024 16:08:30 +0800 Subject: [PATCH 1/2] chore: fix typo for `LOG_COMPRESSION` in ini --- custom/conf/app.example.ini | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/custom/conf/app.example.ini b/custom/conf/app.example.ini index 30eba497b499a..5f29802933cdd 100644 --- a/custom/conf/app.example.ini +++ b/custom/conf/app.example.ini @@ -2688,7 +2688,7 @@ LEVEL = Info ;; Logs retention time in days. Old logs will be deleted after this period. ;LOG_RETENTION_DAYS = 365 ;; Log compression type, `none` for no compression, `zstd` for zstd compression. -;; Other compression types like `gzip` if NOT supported, since seekable stream is required for log view. +;; Other compression types like `gzip` is NOT supported, since seekable stream is required for log view. ;; It's always recommended to use compression when using local disk as log storage if CPU or memory is not a bottleneck. ;; And for object storage services like S3, which is billed for requests, it would cause extra 2 times of get requests for each log view. ;; But it will save storage space and network bandwidth, so it's still recommended to use compression. From b1c52bf9bdfec2e2f6c2533c0ee339d4db9fef59 Mon Sep 17 00:00:00 2001 From: Jason Song Date: Fri, 9 Aug 2024 17:13:32 +0800 Subject: [PATCH 2/2] Update custom/conf/app.example.ini Co-authored-by: silverwind --- custom/conf/app.example.ini | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/custom/conf/app.example.ini b/custom/conf/app.example.ini index 5f29802933cdd..adec5aff36558 100644 --- a/custom/conf/app.example.ini +++ b/custom/conf/app.example.ini @@ -2688,7 +2688,7 @@ LEVEL = Info ;; Logs retention time in days. Old logs will be deleted after this period. ;LOG_RETENTION_DAYS = 365 ;; Log compression type, `none` for no compression, `zstd` for zstd compression. -;; Other compression types like `gzip` is NOT supported, since seekable stream is required for log view. +;; Other compression types like `gzip` are NOT supported, since seekable stream is required for log view. ;; It's always recommended to use compression when using local disk as log storage if CPU or memory is not a bottleneck. ;; And for object storage services like S3, which is billed for requests, it would cause extra 2 times of get requests for each log view. ;; But it will save storage space and network bandwidth, so it's still recommended to use compression.