From f88b41c753ade7fb7855c0bca7ed43599199caac Mon Sep 17 00:00:00 2001 From: jaqra Date: Tue, 27 Aug 2019 22:50:00 +0300 Subject: [PATCH 1/2] Move line number to :before attr to hide from search on browser --- public/css/index.css | 2 +- public/less/_base.less | 11 +++++++---- routers/repo/view.go | 2 +- 3 files changed, 9 insertions(+), 6 deletions(-) diff --git a/public/css/index.css b/public/css/index.css index 6b906cc4a8137..ad1d0313f70b0 100644 --- a/public/css/index.css +++ b/public/css/index.css @@ -216,7 +216,7 @@ footer .ui.left,footer .ui.right{line-height:40px} .inline-grouped-list>.ui{display:block;margin-top:5px;margin-bottom:10px} .inline-grouped-list>.ui:first-child{margin-top:1px} .lines-num{vertical-align:top;text-align:right!important;color:#999;background:#f5f5f5;width:1%;-webkit-user-select:none;-moz-user-select:none;-ms-user-select:none;user-select:none} -.lines-num span{line-height:20px!important;padding:0 10px;cursor:pointer;display:block} +.lines-num span:before{content:attr(data-line-number);line-height:20px!important;padding:0 10px;cursor:pointer;display:block} .lines-code,.lines-num{padding:0!important} .lines-code .hljs,.lines-code ol,.lines-code pre,.lines-num .hljs,.lines-num ol,.lines-num pre{background-color:#fff;margin:0;padding:0!important} .lines-code .hljs li,.lines-code ol li,.lines-code pre li,.lines-num .hljs li,.lines-num ol li,.lines-num pre li{display:block;width:100%} diff --git a/public/less/_base.less b/public/less/_base.less index d961e18c37529..487779c137ff1 100644 --- a/public/less/_base.less +++ b/public/less/_base.less @@ -920,10 +920,13 @@ footer { user-select: none; span { - line-height: 20px !important; - padding: 0 10px; - cursor: pointer; - display: block; + &:before { + content: attr(data-line-number); + line-height: 20px !important; + padding: 0 10px; + cursor: pointer; + display: block; + } } } diff --git a/routers/repo/view.go b/routers/repo/view.go index 9d24506b47ce9..9bf4c50f6d363 100644 --- a/routers/repo/view.go +++ b/routers/repo/view.go @@ -319,7 +319,7 @@ func renderFile(ctx *context.Context, entry *git.TreeEntry, treeLink, rawLink st output.Reset() for i := 0; i < len(lines); i++ { - output.WriteString(fmt.Sprintf(`%d`, i+1, i+1)) + output.WriteString(fmt.Sprintf(``, i+1, i+1)) } ctx.Data["LineNums"] = gotemplate.HTML(output.String()) } From bac6af348ff3e1a84b34a923014cad568aa97f72 Mon Sep 17 00:00:00 2001 From: jaqra <48099350+jaqra@users.noreply.github.com> Date: Tue, 27 Aug 2019 23:40:48 +0300 Subject: [PATCH 2/2] Use same variable in WriteString Co-Authored-By: Lauris BH --- routers/repo/view.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/routers/repo/view.go b/routers/repo/view.go index 9bf4c50f6d363..00790a4ef35be 100644 --- a/routers/repo/view.go +++ b/routers/repo/view.go @@ -319,7 +319,7 @@ func renderFile(ctx *context.Context, entry *git.TreeEntry, treeLink, rawLink st output.Reset() for i := 0; i < len(lines); i++ { - output.WriteString(fmt.Sprintf(``, i+1, i+1)) + output.WriteString(fmt.Sprintf(``, i+1)) } ctx.Data["LineNums"] = gotemplate.HTML(output.String()) }