Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

goenv init - takes much longer time to finish since version 2.2.0 #396

Closed
lukewang1024 opened this issue Aug 15, 2024 · 5 comments · Fixed by #425
Closed

goenv init - takes much longer time to finish since version 2.2.0 #396

lukewang1024 opened this issue Aug 15, 2024 · 5 comments · Fixed by #425

Comments

@lukewang1024
Copy link

Seems like the issue starts from d8de3f4 commit.
@aravind-n
Copy link

+1 I'm experiencing significant slowdowns on login with bash, zsh, and fish

@ChronosMasterOfAllTime
Copy link
Contributor

@reneleonhardt please look into this regression

Merged
@ChronosMasterOfAllTime
Copy link
Contributor

Attempt to fix the perf in goenv-installed in PR #421

@ChronosMasterOfAllTime
Copy link
Contributor

#425 Fixes it; turns out goenv-commands was calling versions in aloop - this can be detrimental to machine performance especially for those with long paths

@ChronosMasterOfAllTime
Copy link
Contributor

@lukewang1024 released in v2.2.14

Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Cache versions and make it faster go-nv/goenv
3 participants
@aravind-n @lukewang1024 @ChronosMasterOfAllTime