Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to close browser process when render process crashed? #526

Closed
VigiZhang opened this issue Dec 29, 2021 · 4 comments
Closed

How to close browser process when render process crashed? #526

VigiZhang opened this issue Dec 29, 2021 · 4 comments
Labels
question Questions related to rod

Comments

@VigiZhang
Copy link

Rod Version: v0.101.0

I'm testing rod on a custom ASAN chrome for a crash.html PoC. Navigating crash.html will make the page crash (with ASAN log printed). How to handle it and close the browser process? In puppeteer I can use page.on('error') and browser.close() will do the close job.

err := rod.Try(func() {
    browser.MustPage("./crash.html").MustWaitIdle()
})

I tried some page.WaitEvent and some error handling method and no success.

@VigiZhang VigiZhang added the question Questions related to rod label Dec 29, 2021
@ysmood
Copy link
Member

ysmood commented Dec 31, 2021

browser.Close()

@VigiZhang
Copy link
Author

Have tried Browser.Close() still cannot close the browser.

@ghost
Copy link

ghost commented Mar 4, 2022

#550

@ysmood
Copy link
Member

ysmood commented Mar 4, 2022

#345 (comment)

@ysmood ysmood closed this as completed Mar 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Questions related to rod
Projects
None yet
Development

No branches or pull requests

2 participants