Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dragging bookmarlet doesn't work #129

Closed
mzch opened this issue May 1, 2019 · 3 comments
Closed

Dragging bookmarlet doesn't work #129

mzch opened this issue May 1, 2019 · 3 comments

Comments

@mzch
Copy link

mzch commented May 1, 2019

I've added bookmarklet in commit 4b93937. To use it, just drag the Add new bookmark button to your bookmark toolbar :

Screencast

When possible (i.e. allowed by CSP), the bookmarklet will show dialog for saving new bookmark :

As dialog

However, if it's not possible, the bookmarklet will redirect you to submit page :

As submit page

Please try it out.


Since you can get a SSL certificate pretty easily and for free through LetsEncrypt, you could maybe integrate auto certificate renewal...

I don't think I will do it, because :

  • It adds new complexity to shiori. Right now I just want to focus on making shiori stable and reliable enough to use.
  • When user self hosted shiori, they usually put it behind a web server anyway, and there are already many good web server that can fetch SSL certificate from Let'sEncrypt, e.g Caddy and nginx.

Originally posted by @RadhiFadlillah in #84 (comment)

@mzch
Copy link
Author

mzch commented May 1, 2019

Hi,

Bookmarklet can’t be dragged to toolbar on Chrome 74.0.3729.108 or later and Safari 12.1.
Is this only my own problem?

@mzch mzch changed the title I've added bookmarklet in commit [4b93937](https://github.com/RadhiFadlillah/shiori/commit/4b939379e83b34f6d9d97517a80b8dd44313bbe8). To use it, just drag the Add new bookmark button to your bookmark toolbar : Dragging bookmarlet doesn't work May 1, 2019
@mzch
Copy link
Author

mzch commented May 1, 2019

Sorry, I found it in About dialog.

@mzch mzch closed this as completed May 1, 2019
@imjoeyli
Copy link

It doesn't work in Shiori v1.5, I can't drag add button now. How did you solve it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants