Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI builds does not take into account RC builds when tagging packages #677

Closed
fmartingr opened this issue Jul 26, 2023 · 0 comments · Fixed by #686
Closed

CI builds does not take into account RC builds when tagging packages #677

fmartingr opened this issue Jul 26, 2023 · 0 comments · Fixed by #686
Assignees
Labels
priority:high type:bug Something isn't working
Milestone

Comments

@fmartingr
Copy link
Member

Describe the bug / actual behavior

The CI uses conditionals to check if the released version is a development version or not (that is, if pushed to a v* tag or not).

When tagging the images, the conditional need to check if the version is a rc version as well.

The workflow should be:

v* tag push to master:

  • gorelease: ok ( build and publish v*)
  • buildx: ok (publishv* and latest)

commit push to master:

  • gorelease: ok (build v*)
  • buildx: ok (publish v*-next-commit and dev)

v*-rc* push to master:

  • gorelease: (build and publish v*-rc*)
  • buildx: build and publish with v*-rc* but not with latest nor dev.

Links

@fmartingr fmartingr added the type:bug Something isn't working label Jul 26, 2023
@fmartingr fmartingr added this to the 1.6.0 milestone Jul 26, 2023
@fmartingr fmartingr self-assigned this Jul 26, 2023
@github-project-automation github-project-automation bot moved this to To do in Roadmap Jul 26, 2023
@fmartingr fmartingr moved this from To do to In progress in Roadmap Jul 30, 2023
@github-project-automation github-project-automation bot moved this from In progress to Done in Roadmap Jul 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority:high type:bug Something isn't working
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant