Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong application path for asset/eventBus.js #962

Closed
nakal opened this issue Aug 10, 2024 · 3 comments · Fixed by #971
Closed

Wrong application path for asset/eventBus.js #962

nakal opened this issue Aug 10, 2024 · 3 comments · Fixed by #971
Labels
type:bug Something isn't working

Comments

@nakal
Copy link

nakal commented Aug 10, 2024

Data

  • Shiori version: 1.7.0
  • Database Engine: PostgreSQL
  • Operating system: FreeBSD
  • CLI/Web interface/Web Extension: Web interface

Describe the bug / actual behavior

Shiori server is running with Nginx in the subpath /shiori. Most assets are loaded properly except eventBus.js. The relevant piece shows that the asset url might be wrong:

<script type="module">
                import basePage from "./assets/js/page/base.js";                                  import pageHome from "./assets/js/page/home.js";
                import pageSetting from "./assets/js/page/setting.js";
                import customDialog from "./assets/js/component/dialog.js";
        import EventBus from "../assets/js/component/eventBus.js";

In the last import you can see "../".

Expected behavior

The asset should probably be loaded from the correct webroot.

To Reproduce

Steps to reproduce the behavior:

  1. Go to 'https://host/webroot'
  2. Examine the web page source.
@nakal nakal added the type:bug Something isn't working label Aug 10, 2024
@github-project-automation github-project-automation bot moved this to To do in Roadmap Aug 10, 2024
@isamert
Copy link

isamert commented Aug 17, 2024

I am also experiencing this, as a workaround I use the following in my nginx configuration for shiori:

        sub_filter ../assets/js/component/eventBus.js ./assets/js/component/eventBus.js;

@Monirzadeh
Copy link
Collaborator

Monirzadeh commented Aug 17, 2024

@fmartingr do I miss something in #916?

@fmartingr
Copy link
Member

I think this is the issue: #971

@github-project-automation github-project-automation bot moved this from To do to Done in Roadmap Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something isn't working
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants