Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: local pipeline execution doesn't work #655

Closed
wass3r opened this issue Jul 31, 2022 · 1 comment · Fixed by go-vela/cli#378
Closed

cli: local pipeline execution doesn't work #655

wass3r opened this issue Jul 31, 2022 · 1 comment · Fixed by go-vela/cli#378
Labels
area/cli Indicates a change to the CLI bug Indicates a bug

Comments

@wass3r
Copy link
Collaborator

wass3r commented Jul 31, 2022

Description

it seems we introduced a regression in "v0.14.0" of the CLI. local pipeline execution via vela exec pipeline .. using the CLI hangs. utilizing "trace" level logging vela --log.level trace exec pipeline, the issues appears to happen right after mounting the volume:

...
time="2022-07-30T16:02:26-05:00" level=trace msg="no-op: assembling build localOrg_localRepo_1"
time="2022-07-30T16:02:26-05:00" level=trace msg="running container step_localOrg_localRepo_1_echo"
time="2022-07-30T16:02:26-05:00" level=trace msg="creating mount for default volume localOrg_localRepo_1"
time="2022-07-30T16:02:26-05:00" level=trace msg="creating mount for volume /home/user/vela-test:/vela/src:rw"

Value

local pipeline execution should be functional for validating/testing pipelines.

Useful Information

simple test pipeline

version: "1"

steps:
  - name: echo
    image: alpine
    commands:
      - echo hello world
  1. What is the output of vela --version?

v0.14.0

  1. What operating system is being used?

macOS & Linux

  1. Any other important details?
@wass3r wass3r added bug Indicates a bug area/cli Indicates a change to the CLI labels Jul 31, 2022
@wass3r
Copy link
Collaborator Author

wass3r commented Jul 31, 2022

it looks like the issue is linked to the changes introduced here: go-vela/worker#317

we didn't make accommodations for these changes in the CLI. after we instantiate the executor we never call .StreamBuild (https://github.com/go-vela/cli/blob/v0.14.0/action/pipeline/exec.go#L108-L155) to handle the stream requests as we do in the worker directly (https://github.com/go-vela/worker/blob/v0.14.0/cmd/vela-worker/exec.go#L135-L143), so the execution via CLI actually hangs here: https://github.com/go-vela/worker/blob/v0.14.0/executor/local/step.go#L107-L112 because of that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cli Indicates a change to the CLI bug Indicates a bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant