Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support LFS in git plugin #673

Closed
colindean opened this issue Sep 6, 2022 · 3 comments · Fixed by go-vela/vela-git#161
Closed

Support LFS in git plugin #673

colindean opened this issue Sep 6, 2022 · 3 comments · Fixed by go-vela/vela-git#161
Labels
area/plugin Indicates a change to a plugin feature Indicates a new feature

Comments

@colindean
Copy link

Description

We're currently using this to pull down tags and LFS.

def pull_git_tag_and_lfs(pull_tags_from_branch):
    return {
        "name": "git-lfs",
        "image": "hub.docker.target.com/gitlab/gitlab-runner:latest",
        "commands": [
            "git lfs pull",
            "git fetch --no-tags origin %s" % pull_tags_from_branch
        ]
    }

The git plugin can pull tags but it still can't pull LFS.

Value

Adding LFS would enable us to use the git plugin and not need to resort to external images.

Definition of Done

Add lfs: true and it just works.

steps:
  - name: clone_hello-world
    image: vela-plugins/git:v0.6.0
    pull: always
    parameters:
      path: hello-world
      ref: refs/heads/master
      remote: https://git.example.com/octocat/hello-world.git
      sha: 7fd1a60b01f91b314f59955a4e4d4e80d8edf11d
      tags: true
      lfs: true
@colindean colindean added the feature Indicates a new feature label Sep 6, 2022
@wass3r wass3r added the area/plugin Indicates a change to a plugin label Sep 8, 2022
@wass3rw3rk
Copy link
Member

denfinitely doable and the size increase is less than what it was adding github-cli (go-vela/vela-git#157) which added over 50MB?!

image size
vela-git 30.3MB
vela-git + github-cli 82.9MB
vela-git + github-cli + git-lfs 90.2MB

@colindean
Copy link
Author

GH CLI has a ton of deps baked in IIRC.

@wass3rw3rk
Copy link
Member

wass3rw3rk commented Aug 28, 2024

ah, i thought it was "just a Go binary" ™️ 😮 i guess it is but with lots of dependencies like you said.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/plugin Indicates a change to a plugin feature Indicates a new feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants