From fac36451384170924028f6eebeff1a2e304fa5bf Mon Sep 17 00:00:00 2001 From: David May <49894298+wass3rw3rk@users.noreply.github.com> Date: Tue, 9 Apr 2024 10:27:19 -0500 Subject: [PATCH 1/2] chore(go): specific go version --- go.mod | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/go.mod b/go.mod index 5a52e83a0..542158b51 100644 --- a/go.mod +++ b/go.mod @@ -1,6 +1,6 @@ module github.com/go-vela/server -go 1.21 +go 1.21.9 require ( github.com/Bose/minisentinel v0.0.0-20200130220412-917c5a9223bb From 291f09482a7195a9e0596ffd89c33b1060dc25e2 Mon Sep 17 00:00:00 2001 From: wass3rw3rk <49894298+wass3rw3rk@users.noreply.github.com> Date: Wed, 10 Apr 2024 16:10:54 -0500 Subject: [PATCH 2/2] fix(actions): temp disable "go fix" in validate there is a bug with "go fix". a fix has been pushed but not yet released. temporarily disabling "go fix" in validate action. ref: https://github.com/golang/go/commit/7fd62ba821b1044e8e4077df052b0a1232672d57 --- .github/workflows/validate.yml | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/.github/workflows/validate.yml b/.github/workflows/validate.yml index ec175ea5b..466a71d51 100644 --- a/.github/workflows/validate.yml +++ b/.github/workflows/validate.yml @@ -36,9 +36,12 @@ jobs: # Check that go fmt ./... produces a zero diff; clean up any changes afterwards. go fmt ./... && git diff --exit-code; code=$?; git checkout -- .; (exit $code) # Check that go fix ./... produces a zero diff; clean up any changes afterwards. - go fix ./... && git diff --exit-code; code=$?; git checkout -- .; (exit $code) + # + # Renable this after https://github.com/golang/go/commit/7fd62ba821b1044e8e4077df052b0a1232672d57 + # has been released. + # go fix ./... && git diff --exit-code; code=$?; git checkout -- .; (exit $code) - name: validate spec run: | sudo make spec-install - make spec \ No newline at end of file + make spec