Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: update helper funcs to methods on structs #17

Merged
merged 5 commits into from
Jan 3, 2020
Merged

refactor: update helper funcs to methods on structs #17

merged 5 commits into from
Jan 3, 2020

Conversation

jbrockopp
Copy link
Contributor

No description provided.

@jbrockopp jbrockopp added the enhancement Indicates an improvement to a feature label Jan 3, 2020
@jbrockopp jbrockopp requested a review from a team as a code owner January 3, 2020 18:44
@jbrockopp jbrockopp self-assigned this Jan 3, 2020
@codecov
Copy link

codecov bot commented Jan 3, 2020 •
edited
Loading

Codecov Report

Merging #17 into master will increase coverage by 0.8%.
The diff coverage is 98.11%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master      #17     +/-   ##
=========================================
+ Coverage   41.76%   42.57%   +0.8%     
=========================================
  Files           4        6      +2     
  Lines         249      249             
=========================================
+ Hits          104      106      +2     
+ Misses        144      143      -1     
+ Partials        1        0      -1
Impacted Files Coverage Δ
cmd/vela-git/build.go 100% <100%> (ø)
cmd/vela-git/repo.go 100% <100%> (ø)
cmd/vela-git/netrc.go 100% <100%> (ø)
cmd/vela-git/plugin.go 25% <92.3%> (-3.31%) ⬇️

wass3r
wass3r approved these changes Jan 3, 2020
View reviewed changes
Copy link
Collaborator

@wass3r wass3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

kneal
kneal approved these changes Jan 3, 2020
View reviewed changes
Copy link

@kneal kneal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐬

@kneal kneal merged commit 598ecc4 into master Jan 3, 2020
@kneal kneal deleted the refactor/methods branch January 3, 2020 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kneal kneal kneal approved these changes

@wass3r wass3r wass3r approved these changes

Assignees

@jbrockopp jbrockopp

Labels
enhancement Indicates an improvement to a feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jbrockopp @wass3r @kneal