Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add comments for code #22

Merged
merged 1 commit into from
Jan 7, 2020
Merged

docs: add comments for code #22

merged 1 commit into from
Jan 7, 2020

Conversation

jbrockopp
Copy link
Contributor

No description provided.

@jbrockopp jbrockopp added the enhancement Indicates an improvement to a feature label Jan 7, 2020
@jbrockopp jbrockopp requested a review from a team as a code owner January 7, 2020 17:21
@jbrockopp jbrockopp self-assigned this Jan 7, 2020
@codecov
Copy link

codecov bot commented Jan 7, 2020 •
edited
Loading

Codecov Report

Merging #22 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #22   +/-   ##
=======================================
  Coverage   50.96%   50.96%           
=======================================
  Files           6        6           
  Lines         259      259           
=======================================
  Hits          132      132           
  Misses        117      117           
  Partials       10       10
Impacted Files Coverage Δ
cmd/vela-git/build.go 100% <ø> (ø) ⬆️
cmd/vela-git/plugin.go 59.18% <ø> (ø) ⬆️
cmd/vela-git/command.go 100% <ø> (ø) ⬆️
cmd/vela-git/netrc.go 100% <ø> (ø) ⬆️
cmd/vela-git/repo.go 100% <ø> (ø) ⬆️

kneal
kneal approved these changes Jan 7, 2020
View reviewed changes
Copy link

@kneal kneal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐬

KellyMerrick
KellyMerrick approved these changes Jan 7, 2020
View reviewed changes
Copy link
Contributor

@KellyMerrick KellyMerrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@KellyMerrick KellyMerrick merged commit 78712be into master Jan 7, 2020
@KellyMerrick KellyMerrick deleted the docs/codecomments branch January 7, 2020 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KellyMerrick KellyMerrick KellyMerrick approved these changes

@kneal kneal kneal approved these changes

Assignees

@jbrockopp jbrockopp

Labels
enhancement Indicates an improvement to a feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jbrockopp @kneal @KellyMerrick