Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use "doctrine/annotations" instead of "doctrine/common" #69

Closed
mpoiriert opened this issue Jul 5, 2013 · 1 comment
Closed

Use "doctrine/annotations" instead of "doctrine/common" #69

mpoiriert opened this issue Jul 5, 2013 · 1 comment
Assignees
Milestone

Comments

@mpoiriert
Copy link

I saw that your are using doctrine/common but I think that you are just using the annotations library.

It would be cleaner to use the specific dependency and might solve future problem since composer will not be able to manage dependency properly (in fact doctrine should change how he made is hierarcy so common have a depency on annotation instead of having the library directly in it...)

@ghost ghost assigned lisachenko Jul 6, 2013
@lisachenko
Copy link
Member

Hi )
There is a reason for doctrine/common dependency: it can be used simpler without composer. For example, when using my library in the application that uses submodules. In that case doctrine/common < 2.4 is only single dependency and can be installed by adding only one submodule. doctrine/annotations depends on doctrine/lexer so installing by hand requires more work.

However, official way for my library is to use a composer and I'll update this dependency soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants