Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug for aggregating calculations in heatmaps #1933

Closed
metemaddar opened this issue Feb 10, 2023 · 2 comments
Closed

Fix bug for aggregating calculations in heatmaps #1933

metemaddar opened this issue Feb 10, 2023 · 2 comments
Assignees

Comments

@metemaddar
Copy link
Contributor

metemaddar commented Feb 10, 2023

Previously the calculation was done before finding parents. This was a problem in resolutions below 10 to have some different values per hexagon. At generation of geojson, only the last value was applied to the result.

@metemaddar metemaddar self-assigned this Feb 10, 2023
@metemaddar metemaddar added this to the v1.5 milestone Feb 10, 2023
@metemaddar
Copy link
Contributor Author

metemaddar commented Feb 10, 2023

Now the process of finding parent is before doing calculations. So the calculation is now done per parent (Target resolution).

The problem now is that the parenting function, became a tight bottle neck. Because previously we ran the parenting on unique grid_ids, And now we run it on the input data. The performance of parenting is improved by using a cache (~25%). But it's still a bottle neck.

At largest request example, it takes around 5 seconds to run parenting.

@p4b-bro
Copy link

p4b-bro bot commented Jun 6, 2023

This task/issue closed on Tue Jun 06 2023 ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants