Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[regression] cdac1a6 broke successive alignments of a same range in some cases #79

Open
sim590 opened this issue Dec 31, 2024 · 0 comments

Comments

@sim590
Copy link

sim590 commented Dec 31, 2024

Let's say you have this starting text:

int thisVariable = callingThisFunction(thisArg, thisOtherArgument, 0);
                   callingThisFunction(noThisArgumentNowHere, nowThisArg, 0);
                   callingThisFunction(thisArg, hereIcomeWithAnotherArgument, 0);

since cdac1a6, if you use GTabularize argument_list, then you get:

int thisVariable = callingThisFunction(thisArg,               thisOtherArgument,            0);
callingThisFunction                   (noThisArgumentNowHere, nowThisArg,                   0);
callingThisFunction                   (thisArg,               hereIcomeWithAnotherArgument, 0);

instead of the proper:

int thisVariable = callingThisFunction(thisArg,               thisOtherArgument,            0);
                   callingThisFunction(noThisArgumentNowHere, nowThisArg,                   0);
                   callingThisFunction(thisArg,               hereIcomeWithAnotherArgument, 0);

which you do get on the parent of cdac1a6.

I don't know what cdac1a6 does fix really, but I have not noticed any clear advantage since I updated to cdac1a6, but I got this really annoying regression.

Since there is no mention of an issue linked to cdac1a6 supporting it, I'm wondering if it is really useful. The explanation in the commit only states that the approach to indentation has changed, but what does it fix?

For now, I will config my Vimrc to use tabular at the version prior to cdac1a6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant